В этой теме 4 ответа, 3 участника, последнее обновление 
Просмотр 5 сообщений - с 1 по 5 (из 5 всего)
-
Сообщения
-
Вообщем такая проблема, враг когда умирает (life == false) он не удаляется, остается на карте и продолжает двигаться, (притом команды срабатывают, мой герой все время прыгает вверх, касаясь врага), вот итератор и лист:
12345std::list<Entity*> enemyArray;std::list<Entity*>::iterator iter1;std::vector<Object> e = lvl.GetObjects("EasyEnemy");for (int i = 0; i < e.size(); i++)enemyArray.push_back(new Enemy(easyEnemyImage, lvl, e[i].rect.left, e[i].rect.top, 79, 59, "EasyEnemy"));Вот логика:
1234567891011121314151617181920212223242526272829for (iter1 = enemyArray.begin(); iter1 != enemyArray.end();){(*iter1)->update(time);if ((*iter1)->life == false){iter1 = enemyArray.erase(iter1);delete (*iter1);}else { iter1++; }}for (iter1 = enemyArray.begin(); iter1 != enemyArray.end(); iter1++){if (p.getRect().intersects((*iter1)->getRect())){if ((*iter1)->name == "EasyEnemy"){if ((p.dy > 0) && (p.onGround == false)){(*iter1)->health = 0;p.dy -= 0.5;}else{(*iter1)->dx -= 0.2;}}}}Вот рисование врага:
1234for (iter1 = enemyArray.begin(); iter1 != enemyArray.end(); iter1++){window.draw((*iter1)->sprite);}Пытался менять разными способами, тоесть делать типо если жизнь равна нулю то удаляем, менял команды удаления местами: результат один и тот же, жизнь врага false, но он остается и не удаляется
Вот весь код main.cpp:
123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580#include <SFML/Graphics.hpp>#include <SFML/Audio.hpp>#include "view.h"#include <iostream>#include <sstream>#include "mission.h"#include "iostream"#include "level.h"#include <vector>#include <list>#include "tinyxml\tinyxml.h"using namespace sf;class Entity {public:std::vector<Object> obj;float dx, dy, x, y, speed, moveTimer;int w, h, health;bool life, isMove, onGround;Texture texture;Sprite sprite;String name;Entity(Image &image, float X, float Y, int W, int H, String Name) {x = X; y = Y; w = W; h = H; name = Name; moveTimer = 0;speed = 0;dx = 0; dy = 0;life = true; onGround = false; isMove = false;texture.loadFromImage(image);sprite.setTexture(texture);sprite.setOrigin(w / 2, h / 2);}FloatRect getRect(){return FloatRect(x, y, w, h);}virtual void update(float time) = 0;};class Player :public Entity {public:int health = 100;enum { left, right, jump, stay } state;int playerScore;Music death;Music deathS;Music death2;Music soundtrack;Music soundtrack2;Music claySong;int Pcounter = 0;int Dcounter = 0;SoundBuffer lowhpBuffer;Sound lowhp;//SoundBuffer cB;//Sound s;Player(Image &image, Level &lev, float X, float Y, int W, int H, String Name) :Entity(image, X, Y, W, H, Name){playerScore = 0; state = stay; obj = lev.GetAllObjects();lowhpBuffer.loadFromFile("sounds/lowhp.ogg");lowhp.setBuffer(lowhpBuffer);//cB.loadFromFile("d");//s.setBuffer(cB);death.openFromFile("music/death.ogg"); death.setLoop(true);deathS.openFromFile("music/deathS.ogg"); deathS.setVolume(100); deathS.setLoop(true);death2.openFromFile("music/death2.ogg"); death2.setVolume(100);soundtrack.openFromFile("music/soundtrack.ogg"); soundtrack.setVolume(50);soundtrack2.openFromFile("music/soundtrack2.ogg");claySong.openFromFile("sounds/claySong.ogg");soundtrack.play(); soundtrack.setLoop(true);claySong.play(); claySong.setLoop(true);if (name == "Player1"){sprite.setTextureRect(IntRect(10, 306, w, h));}}void control() {if (life == true) {if (Keyboard::isKeyPressed(Keyboard::A)) {state = left;speed = 0.3;}if (Keyboard::isKeyPressed(Keyboard::D)) {state = right;speed = 0.3;}if ((Keyboard::isKeyPressed(Keyboard::Space) && (onGround == true))) {state = jump;dy = -0.5;//onGround = false;}}}void update(float time){control();switch (state) {case left: dx = -speed; break;case right: dx = speed; break;case jump: break;case stay: break;}x += dx*time;checkCollisionWithMap(dx, 0);y += dy*time;checkCollisionWithMap(0, dy);if (!isMove) speed = 0;sprite.setPosition(x + w / 2, y + h / 2);if (health <= 0) { life = false; }if (life == true) { getplayercoordinateforview(x, y); }dy = dy + 0.0015*time;if (life == false){if (Dcounter < 3000) {Dcounter++;if ((Dcounter >= 0) && (Dcounter < 300)) {sprite.setColor(Color(235, 65, 7));view.zoom(0.997);view.move(0, -0.05);view.rotate(0.2);}if ((Dcounter >= 300) && (Dcounter < 600)) {view.rotate(-0.2);view.zoom(0.997);view.move(0.2, 0.2);}if ((Dcounter >= 600) && (Dcounter < 670)) {view.zoom(0.990);view.move(0, -0.3);}if ((Dcounter >= 670) && (Dcounter < 900)) {view.move(-0.3, 0);deathS.stop();}if ((Dcounter >= 900) && (Dcounter < 2100)) {view.zoom(1.005);view.move(0.2, 0);if (Dcounter >= 1000) {view.rotate(-0.5);if (death.getVolume() > 26) {death.setVolume(25);}if (death2.getStatus() == Sound::Playing) {}else{death2.play();}}}if ((Dcounter >= 2100) && (Dcounter < 2500)) {view.setSize(640, 400);view.setRotation(0);view.move(0.2, 0);}if (Dcounter >= 2500) {view.zoom(1.1);}}if (death.getStatus() == Sound::Playing){}else{soundtrack.stop();soundtrack2.stop();claySong.stop();death.play();deathS.play();}}}float getplayercoordinateX() {return x;}void checkCollisionWithMap(float Dx, float Dy) {onGround = false;for (int i = 0; i<obj.size(); i++)if (getRect().intersects(obj[i].rect)){if (obj[i].name == "solid"){if (Dy>0) { y = obj[i].rect.top - h; dy = 0; onGround = true; }if (Dy<0) { y = obj[i].rect.top + obj[i].rect.height; dy = 0; }if (Dx>0) { x = obj[i].rect.left - w; }if (Dx<0) { x = obj[i].rect.left + obj[i].rect.width; }}if (obj[i].name == "lava"){if (Dy>0) { y = obj[i].rect.top - h; dy = 0; onGround = true; }if (Dy<0) { y = obj[i].rect.top + obj[i].rect.height; dy = 0; }if (Dx>0) { x = obj[i].rect.left - w; }if (Dx < 0) { x = obj[i].rect.left + obj[i].rect.width; }if (life = true) { health = 0; }}if (obj[i].name == "batut"){if (Dy > 0) { y = obj[i].rect.top - h; dy = 0; }if (Dy < 0) { y = obj[i].rect.top + obj[i].rect.height; dy = 0; }if (Dx > 0) { x = obj[i].rect.left - w; }if (Dx < 0) { x = obj[i].rect.left + obj[i].rect.width; }dy -= 1.5; onGround = false;}if (obj[i].name == "enemy"){soundtrack.stop();claySong.stop();if (soundtrack2.getStatus() == Sound::Playing) { continue; }else {soundtrack2.play();}sprite.setColor(Color(237, 28, 36));}if (obj[i].name == "poison"){if (life == true) {Pcounter++;if (Pcounter >= 200) {health -= 25;Pcounter = 0;lowhp.play();}}}}}};class Enemy :public Entity{public:int health;Enemy(Image &image, Level &lvl, float X, float Y, int W, int H, String Name) :Entity(image, X, Y, W, H, Name) {obj = lvl.GetObjects("solid"); health = 100;if (name == "EasyEnemy") {health = 100;sprite.setTextureRect(IntRect(0, 0, w, h));dx = 0.1;}}void checkCollisionWithMap(float Dx, float Dy) {for (int i = 0; i<obj.size(); i++)if (getRect().intersects(obj[i].rect)){if (Dy>0) { y = obj[i].rect.top - h; dy = 0; onGround = true; }if (Dy<0) { y = obj[i].rect.top + obj[i].rect.height; dy = 0; }if (Dx>0) { x = obj[i].rect.left - w; dx = -0.1; sprite.scale(-1, 1); }if (Dx<0) { x = obj[i].rect.left + obj[i].rect.width; dx = 0.1; sprite.scale(-1, 1); }}}void update(float time) {if (name == "EasyEnemy"){//moveTime += time; if (moveTimer>3000) {dx*=-1; moveTimer = 0; }checkCollisionWithMap(dx, 0);x += dx*time;sprite.setPosition(x + w / 2, y + h / 2); // ЭТО КСТАТИ ЗАДАЕТ ПОЗИЦИЮ СПРАЙТА В КГО ЦЕНТРif (health <= 0) { life = false; }}}};int main(){sf::RenderWindow window(sf::VideoMode(1980, 1080), "Glinskii Adventures");view.reset(sf::FloatRect(0, 0, 640, 400));window.setFramerateLimit(90); // fps//int iterCounter = 0;Level lvl;lvl.LoadFromFile("mainmap.tmx");Image heroImage;heroImage.loadFromFile("images/hero.jpg");heroImage.createMaskFromColor(Color(125, 99, 86));Image easyEnemyImage;easyEnemyImage.loadFromFile("images/enemy1.jpg");easyEnemyImage.createMaskFromColor(Color(255, 255, 255));/*Image map_image;map_image.loadFromFile("images/map.png");Texture map;map.loadFromImage(map_image);Sprite map_sprite;map_sprite.setTexture(map);Image house_image;house_image.loadFromFile("images/house.png");house_image.createMaskFromColor(Color(255, 255, 255));Texture house;house.loadFromImage(house_image);Sprite house_sprite;house_sprite.setTexture(house);house_sprite.setPosition(80, 539);*/Image quest_image;quest_image.loadFromFile("images/tab.jpg");Texture quest_texture;quest_texture.loadFromImage(quest_image);Sprite s_quest;s_quest.setTexture(quest_texture);s_quest.setTextureRect(IntRect(0, 0, 224, 352));/*Image map2;map2.loadFromFile("images/map2.png");Texture map2texture;map2texture.loadFromImage(map2);Sprite map2s;map2s.setTexture(map2texture);*/Object player = lvl.GetObject("player");Object easyEnemyObject = lvl.GetObject("easyEnemy");/*SoundBuffer lowhpBuffer;lowhpBuffer.loadFromFile("sounds/lowhp.ogg");Sound lowhp(lowhpBuffer);*//*SoundBuffer walkBuffer;walkBuffer.loadFromFile("sounds/walk.ogg");Sound walk(walkBuffer);walk.setVolume(100);*/Font font;font.loadFromFile("fonts/classic.TTF");Text text("", font, 20);text.setStyle(Text::Bold);Text pickText("", font, 20);pickText.setStyle(Text::Bold);Text text2("", font, 20);text2.setStyle(Text::Bold);Text glinPlate("", font, 20);glinPlate.setStyle(Text::Bold);glinPlate.setStyle(Text::Underlined);Text nickname("", font, 20);std::list<Entity*> enemyArray;std::list<Entity*>::iterator iter1;std::vector<Object> e = lvl.GetObjects("EasyEnemy");for (int i = 0; i < e.size(); i++)enemyArray.push_back(new Enemy(easyEnemyImage, lvl, e[i].rect.left, e[i].rect.top, 79, 59, "EasyEnemy"));/*std::list<Entity*> entities;std::list<Entity*>::iterator it;std::vector<Object> e = lvl.GetObjects("EasyEnemy");for (int i = 0; i < e.size(); i++)entities.push_back(new Enemy(easyEnemyImage, lvl, e[i].rect.left, e[i].rect.top, 79, 59, "EasyEnemy"));*/Player p(heroImage, lvl, player.rect.left, player.rect.top, 70, 86, "Player1");//Enemy easyEnemy(easyEnemyImage, lvl, easyEnemyObject.rect.left, easyEnemyObject.rect.top, 79, 59, "EasyEnemy");//float CurrentFrame = 0;Clock clock;Clock gameTimeClock;int gameTime = 0;bool showMissionText = true;while (window.isOpen()){float time = clock.getElapsedTime().asMicroseconds();clock.restart();time = time / 800;if (p.life == true) gameTime = gameTimeClock.getElapsedTime().asSeconds();sf::Event event;while (window.pollEvent(event)){window.setKeyRepeatEnabled(false);if (event.type == sf::Event::Closed)window.close();/*if (p.life == true){if ((event.type == Event::KeyPressed) && (event.key.code == Keyboard::D)){walk.play();}}*//*if (p.life == false) {if (death.getStatus() == Sound::Playing) {continue;}else{soundtrack.stop();claySong.stop();death.play();deathS.play();}}*/if ((event.type == Event::KeyPressed) && (event.key.code == Keyboard::Tab)){switch (showMissionText){case true:{std::ostringstream task;task << getTextMission(getCurrentMission(p.getplayercoordinateX()));text2.setString("\n" + task.str());showMissionText = false;glinPlate.setString("Глиняная плита гласит:");nickname.setString("XxX_Daun_XxX");break;}case false:{text2.setString("");showMissionText = true;break;}}}}/*for (iter1 = enemyArray.begin(); iter1 != enemyArray.end(); iter1++){window.draw(enemyArray[iterCounter].getRect);iterCounter++;}*//*for (iter1 = enemyArray.begin(); iter1 != enemyArray.end();){(*iter1)->update(time);if ((*iter1)->health = 0){iter1 = enemyArray.erase(iter1);delete (*iter1);}else iter1++;}*/for (iter1 = enemyArray.begin(); iter1 != enemyArray.end();){(*iter1)->update(time);if ((*iter1)->life == false){delete (*iter1);iter1 = enemyArray.erase(iter1);}else { iter1++; }}for (iter1 = enemyArray.begin(); iter1 != enemyArray.end(); iter1++){if (p.getRect().intersects((*iter1)->getRect())){if ((*iter1)->name == "EasyEnemy"){if ((p.dy > 0) && (p.onGround == false)){(*iter1)->health = 0;p.dy -= 0.5;}else{(*iter1)->dx -= 0.2;}}}}p.update(time);/* for (it = entities.begin(); it != entities.end();){//Entity *b = *it;(*it)->update(time);if ((*it)->life == false){it = entities.erase(it);delete (*it);}else { it++; }}for (it = entities.begin(); it != entities.end(); it++){if ((*it)->getRect().intersects(p.getRect()));{if ((*it)->name == "EasyEnemy"){if ((p.dy > 0) && (p.onGround == false)){}else{}}}}*//*for (it = entities.begin(); it != entities.end(); it++) {(*it)->update(time);}*/changeview();window.setView(view);window.clear();lvl.Draw(window);std::ostringstream playerHealthString, gameTimeString;playerHealthString << p.health; gameTimeString << gameTime;text.setString("Здоровье: " + playerHealthString.str() + "\nВремя игры: " + gameTimeString.str());text.setPosition(view.getCenter().x - 315, view.getCenter().y - 200);window.draw(text);std::ostringstream playerScoreString;playerScoreString << p.playerScore;pickText.setString("Собрано: " + playerScoreString.str());pickText.setPosition(view.getCenter().x + 140, view.getCenter().y - 200);window.draw(pickText);if (!showMissionText){text2.setPosition(view.getCenter().x - 315, view.getCenter().y - 100);s_quest.setPosition(view.getCenter().x - 320, view.getCenter().y - 100);glinPlate.setPosition(view.getCenter().x - 315, view.getCenter().y - 100);nickname.setPosition(view.getCenter().x - 20, view.getCenter().y);window.draw(s_quest); window.draw(text2); window.draw(glinPlate); window.draw(nickname);}for (iter1 = enemyArray.begin(); iter1 != enemyArray.end(); iter1++){window.draw((*iter1)->sprite);}window.draw(p.sprite);window.display();}return 0;}12345678910for (iter1 = enemyArray.begin(); iter1 != enemyArray.end();){(*iter1)->update(time);if ((*iter1)->life == false){iter1 = enemyArray.erase(iter1);delete (*iter1);}else { iter1++; }}Собственно, что вы пытались данной конструкцией донести до машины? Что бы создавался новый обьект на месте старого с полной копией его параметров?
iter1 даже после enemyArray.erase(iter1) будет сохранять ссылку на ОБЪЕКТ, при этом ссылка из листа будет удалена. Убери лишнее приведение и обьект будет успешно удалён.1234567891011for (iter1 = enemyArray.begin(); iter1 != enemyArray.end();){(*iter1)->update(time);if ((*iter1)->life == false){/*iter1 = */enemyArray.erase(iter1);delete (*iter1);iter1++;//Мы работаем с сылкой на обьект в листе, а не индексом в векторе}else { iter1++; }}Крч, я сделал как ты сказал:
1234567891011for (iter1 = enemyArray.begin(); iter1 != enemyArray.end();){(*iter1)->update(time);if ((*iter1)->life == false){enemyArray.erase(iter1);delete (*iter1);iter1++;}else { iter1++; }}Ничего не изменилось, враг все еще на карте при убийстве
При помощи дебага проверь попадает ли вобще код в
<div id=”crayon-591320f37a462315167078-4″ class=”crayon-line crayon-striped-line”><span class=”crayon-st”>if</span> <span class=”crayon-sy”>(</span><span class=”crayon-sy”>(</span><span class=”crayon-o”>*</span><span class=”crayon-v”>iter1</span><span class=”crayon-sy”>)</span><span class=”crayon-o”>-></span><span class=”crayon-v”>life</span> <span class=”crayon-o”>==</span> <span class=”crayon-t”>false</span><span class=”crayon-sy”>)</span></div>
<div id=”crayon-591320f37a462315167078-5″ class=”crayon-line”><span class=”crayon-sy”>{</span></div>
<div id=”crayon-591320f37a462315167078-6″ class=”crayon-line crayon-striped-line”><span class=”crayon-v”>enemyArray</span><span class=”crayon-sy”>.</span><span class=”crayon-e”>erase</span><span class=”crayon-sy”>(</span><span class=”crayon-v”>iter1</span><span class=”crayon-sy”>)</span><span class=”crayon-sy”>;//Ставь точку дебага здесь и убей противника</span></div>
<div id=”crayon-591320f37a462315167078-7″ class=”crayon-line”><span class=”crayon-e”>delete</span> <span class=”crayon-sy”>(</span><span class=”crayon-o”>*</span><span class=”crayon-v”>iter1</span><span class=”crayon-sy”>)</span><span class=”crayon-sy”>;</span></div>
<div id=”crayon-591320f37a462315167078-8″ class=”crayon-line crayon-striped-line”><span class=”crayon-v”>iter1</span><span class=”crayon-o”>++</span><span class=”crayon-sy”>;</span></div>
<div id=”crayon-591320f37a462315167078-9″ class=”crayon-line”><span class=”crayon-sy”>}</span></div>spoty76, вопрос ещё актуален? Я вроде сталкивался с похожей проблемой.
Просмотр 5 сообщений - с 1 по 5 (из 5 всего)
Для ответа в этой теме необходимо авторизоваться.